VolkerE has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385223 )
Change subject: Align anonymous settings dialog appearance with style guide
......................................................................
Align anonymous settings dialog appearance with style guide
Aligning anonymous settings dialog appearance with dialogs
elsewhere by
- setting base `font-size` to 14px to conform with Vector elsewhere –
size is not inherited to the dialog as it's a direct child of `body`
- increasing contrast on descriptive paragraphs to conform with
WCAG level AA
- reducing inner `padding`s slighty to conform with 8px grid
- aligning `border-color` and `box-shadow` values
- replacing static value with LESS variable
Also removing stylelintrc override rule which has been only around
for the old `box-shadow` value.
Bug: T178607
Change-Id: I738e0be11f3d1c94ea03288e0dddc1b983a6c729
---
M .stylelintrc.json
M resources/ext.popups/styles/ext.popups.settings.less
2 files changed, 16 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups
refs/changes/23/385223/1
diff --git a/.stylelintrc.json b/.stylelintrc.json
index b5ef06f..449f45b 100644
--- a/.stylelintrc.json
+++ b/.stylelintrc.json
@@ -2,7 +2,6 @@
"extends": "stylelint-config-wikimedia",
"rules": {
"selector-no-id": null,
- "length-zero-no-unit": null,
"no-descending-specificity": null
}
}
diff --git a/resources/ext.popups/styles/ext.popups.settings.less
b/resources/ext.popups/styles/ext.popups.settings.less
index cf87440..07f5c18 100644
--- a/resources/ext.popups/styles/ext.popups.settings.less
+++ b/resources/ext.popups/styles/ext.popups.settings.less
@@ -5,10 +5,14 @@
position: fixed;
z-index: 1000;
background: #fff;
- width: 450px;
- border: 1px solid #ccc;
- box-shadow: 0px 1px 1px rgba( 0, 0, 0, 0.1 );
- border-radius: 2px;
+ width: 420px;
+ border: 1px solid #a2a9b1;
+ box-shadow: 0 2px 2px 0 rgba( 0, 0, 0, 0.25 );
+ border-radius: @borderRadius;
+
+ .skin-vector & {
+ font-size: 0.875em; // not inherited from `.mw-body-content`,
as we insert at `body`
+ }
header {
.box-sizing( border-box );
@@ -30,6 +34,7 @@
width: 100%;
font-family: sans-serif;
font-size: 18px;
+ font-weight: bold;
text-align: center;
}
}
@@ -37,13 +42,17 @@
main {
display: block;
width: 350px;
- padding: 50px 0 40px;
+ padding: 32px 0 24px;
margin: 0 auto;
p {
- color: #999;
+ color: #54595d;
font-size: 17px;
- margin: 0 0 20px 0;
+ margin: 16px 0 0;
+
+ &:first-child {
+ margin-top: 0;
+ }
}
form {
--
To view, visit https://gerrit.wikimedia.org/r/385223
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I738e0be11f3d1c94ea03288e0dddc1b983a6c729
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
