Hoo man has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385323 )
Change subject: Fix ItemNotabilityFilter in case a page prop is not set
......................................................................
Fix ItemNotabilityFilter in case a page prop is not set
Bug: T178650
Change-Id: If90c5863565d48c32e107fc6c55a19edc2bb9e99
---
M includes/ItemNotabilityFilter.php
1 file changed, 7 insertions(+), 6 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder
refs/changes/23/385323/1
diff --git a/includes/ItemNotabilityFilter.php
b/includes/ItemNotabilityFilter.php
index b71bbb5..0d5d1a0 100644
--- a/includes/ItemNotabilityFilter.php
+++ b/includes/ItemNotabilityFilter.php
@@ -79,13 +79,14 @@
$numericItemIds = [];
- $statementClaimsCount = $this->getStatementClaimsCount(
$itemIds );
+ $pagePropsByItem = $this->getPagePropsByItem( $itemIds );
foreach ( $itemIds as $itemId ) {
$itemIdSerialization = $itemId->getSerialization();
+ $pageProps = $pagePropsByItem[$itemIdSerialization];
- if (
$statementClaimsCount[$itemIdSerialization]['wb-claims'] >= self::MIN_STATEMENTS
- &&
$statementClaimsCount[$itemIdSerialization]['wb-sitelinks'] >=
self::MIN_SITELINKS
+ if ( isset( $pageProps['wb-claims'] ) && isset(
$pageProps['wb-sitelinks'] ) &&
+ $pageProps['wb-claims'] >= self::MIN_STATEMENTS
&& $pageProps['wb-sitelinks'] >= self::MIN_SITELINKS
) {
$numericItemIds[] = $itemId->getNumericId();
}
@@ -99,9 +100,9 @@
*
* @param ItemId[] $itemIds
*
- * @return array() int[page_title][propname] => value
+ * @return int[][] Map of page_title => propname => numeric value
*/
- private function getStatementClaimsCount( array $itemIds ) {
+ private function getPagePropsByItem( array $itemIds ) {
$statementsClaimsCount = [];
$dbr = $this->connectionManager->getReadConnection();
@@ -111,7 +112,7 @@
$this->connectionManager->releaseConnection( $dbr );
foreach ( $res as $row ) {
-
$statementsClaimsCount[$row->page_title][$row->pp_propname] = $row->pp_value ?:
0;
+
$statementsClaimsCount[$row->page_title][$row->pp_propname] = intval(
$row->pp_value ?: 0 );
}
return $statementsClaimsCount;
--
To view, visit https://gerrit.wikimedia.org/r/385323
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If90c5863565d48c32e107fc6c55a19edc2bb9e99
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
