Mholloway has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385376 )
Change subject: Hygiene: Simplify extmetadata collection
......................................................................
Hygiene: Simplify extmetadata collection
Bug: T177430
Change-Id: I2bda0b6bf9abc5759be70163cbfe5afd7cb5466c
---
M lib/gallery.js
1 file changed, 3 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps
refs/changes/76/385376/1
diff --git a/lib/gallery.js b/lib/gallery.js
index 629132b..95232b3 100644
--- a/lib/gallery.js
+++ b/lib/gallery.js
@@ -11,20 +11,14 @@
function getExtMetadataValues(extmetadata) {
const ext = {};
- for (const key in extmetadata) {
- if ({}.hasOwnProperty.call(extmetadata, key)) {
- const value = extmetadata[key].value;
- if (typeof value === 'string') {
- ext[key] = value.trim();
- }
- }
- }
+ Object.keys(extmetadata).forEach((key) => {
+ ext[key] = extmetadata[key].value;
+ });
return ext;
}
function handleGalleryItems(item) {
let obj;
-
if (item.imageinfo) {
obj = item.imageinfo[0];
} else if (item.videoinfo) {
--
To view, visit https://gerrit.wikimedia.org/r/385376
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2bda0b6bf9abc5759be70163cbfe5afd7cb5466c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
