Adamw has submitted this change and it was merged.
Change subject: On load; Geotarget selector no longer hides
......................................................................
On load; Geotarget selector no longer hides
Bug where the geotargetted multiselected would hide on campaign
load even if the checkbox was checked.
Change-Id: I956ecbe88b02f467dd130bc921087ae2e7ffaf3f
---
M modules/ext.centralNotice.interface/centralnotice.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adamw: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.centralNotice.interface/centralnotice.js
b/modules/ext.centralNotice.interface/centralnotice.js
index 859b96a..57f2399 100644
--- a/modules/ext.centralNotice.interface/centralnotice.js
+++ b/modules/ext.centralNotice.interface/centralnotice.js
@@ -113,7 +113,7 @@
$('select[multiple="multiple"]').multiselect({sortable: false,
dividerLocation: 0.5});
// Reveal the geoMultiSelector when the geotargetted checkbox is checked
- if( !$('#geotargeted' ).checked ) {
+ if( !$( '#geotargeted' ).prop( 'checked' ) ) {
$( '#geoMultiSelector' ).fadeOut( 'fast' );
}
$( '#geotargeted' ).click(function () {
--
To view, visit https://gerrit.wikimedia.org/r/55161
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I956ecbe88b02f467dd130bc921087ae2e7ffaf3f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Mwalker <[email protected]>
Gerrit-Reviewer: Adamw <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
