jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/379235 )
Change subject: Normalize IPv6 addresses in Special:AbuseFilter/test ...................................................................... Normalize IPv6 addresses in Special:AbuseFilter/test Forcing user namespace will handle IPv6 correctly as well as possible "User:" prefix supported by the former code. Bug: T176045 Change-Id: I0b4a5468ca44799cade0b0774d749e05d4ff5865 --- M includes/Views/AbuseFilterViewTestBatch.php 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Huji: Looks good to me, but someone else must approve Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/Views/AbuseFilterViewTestBatch.php b/includes/Views/AbuseFilterViewTestBatch.php index abc33fc..e039c61 100644 --- a/includes/Views/AbuseFilterViewTestBatch.php +++ b/includes/Views/AbuseFilterViewTestBatch.php @@ -176,15 +176,7 @@ } // Normalise username - $userTitle = Title::newFromText( $testUsername ); - - if ( $userTitle && $userTitle->getNamespace() == NS_USER ) { - $this->mTestUser = $userTitle->getText(); // Allow User:Blah syntax. - } elseif ( $userTitle ) { - // Not sure of the value of prefixedText over text, but no need to munge unnecessarily. - $this->mTestUser = $userTitle->getPrefixedText(); - } else { - $this->mTestUser = null; // No user specified. - } + $userTitle = Title::newFromText( $testUsername, NS_USER ); + $this->mTestUser = $userTitle ? $userTitle->getText() : null; } } -- To view, visit https://gerrit.wikimedia.org/r/379235 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b4a5468ca44799cade0b0774d749e05d4ff5865 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/AbuseFilter Gerrit-Branch: master Gerrit-Owner: Matěj Suchánek <matejsuchane...@gmail.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Huji <huji.h...@gmail.com> Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com> Gerrit-Reviewer: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: Matěj Suchánek <matejsuchane...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits