Ottomata has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/385989 )
Change subject: Add kafka.offset.store.method config
......................................................................
Add kafka.offset.store.method config
Bug: T178432
Change-Id: I881bbdc2a43bb59b987920feed8c530d85e23656
---
M manifests/init.pp
M templates/kafkatee.conf.erb
2 files changed, 18 insertions(+), 11 deletions(-)
Approvals:
Ottomata: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/manifests/init.pp b/manifests/init.pp
index 2a7eb98..dbeaa22 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -6,6 +6,7 @@
#
# == Parameters:
# $kafka_brokers - Array of Kafka broker addresses.
+# $kafka_offset_store_method - Ether 'none', 'file', or 'broker'. Default:
file
# $kafka_offset_store_path - Path in which to store consumed Kafka offsets.
# Default: /var/cache/kafkatee/offsets
# $kafka_offset_reset - Where to consume from if the offset from which
to
@@ -49,17 +50,18 @@
class kafkatee (
$kafka_brokers,
- $kafka_offset_store_path = '/var/cache/kafkatee/offsets',
- $kafka_offset_reset = 'largest',
- $kafka_message_max_bytes = undef,
- $kafka_group_id = $::fqdn,
- $pidfile = '/var/run/kafkatee/kafkatee.pid',
- $log_statistics_file = '/var/cache/kafkatee/kafkatee.stats.json',
- $log_statistics_interval = 60,
- $output_encoding = 'string',
- $output_format = undef,
- $output_queue_size = undef,
- $configure_rsyslog = true,
+ $kafka_offset_store_method = 'file',
+ $kafka_offset_store_path = '/var/cache/kafkatee/offsets',
+ $kafka_offset_reset = 'largest',
+ $kafka_message_max_bytes = undef,
+ $kafka_group_id = $::fqdn,
+ $pidfile = '/var/run/kafkatee/kafkatee.pid',
+ $log_statistics_file = '/var/cache/kafkatee/kafkatee.stats.json',
+ $log_statistics_interval = 60,
+ $output_encoding = 'string',
+ $output_format = undef,
+ $output_queue_size = undef,
+ $configure_rsyslog = true,
)
{
package { 'kafkatee':
diff --git a/templates/kafkatee.conf.erb b/templates/kafkatee.conf.erb
index 9f7fb83..effefcb 100644
--- a/templates/kafkatee.conf.erb
+++ b/templates/kafkatee.conf.erb
@@ -50,6 +50,11 @@
# Default: none
kafka.metadata.broker.list = <%= Array(@kafka_brokers).sort.join(',') %>
+
+# Offset commit store method: 'file' - local file store (offset.store.path,
et.al),
+# 'broker' - broker commit store (requires Apache Kafka 0.8.2 or later on the
broker).
+kafka.offset.store.method=<%= @kafka_offset_store_method %>
+
# Offset file directory.
# Each topic + partition combination has its own offset file.
# Default: current directory
--
To view, visit https://gerrit.wikimedia.org/r/385989
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I881bbdc2a43bb59b987920feed8c530d85e23656
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet/kafkatee
Gerrit-Branch: master
Gerrit-Owner: Ottomata <ao...@wikimedia.org>
Gerrit-Reviewer: Ottomata <ao...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
