[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix infinite recursion in standalone diff dialog

[Esanders (Code Review)]

Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386003 )

Change subject: Fix infinite recursion in standalone diff dialog
......................................................................

Fix infinite recursion in standalone diff dialog

Change-Id: I90fb54aad642e61cf17105a5c77d1e95cfe33b54
---
M src/ui/dialogs/ve.ui.DiffDialog.js
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/03/386003/1

diff --git a/src/ui/dialogs/ve.ui.DiffDialog.js 
b/src/ui/dialogs/ve.ui.DiffDialog.js
index 4710d3d..6904d89 100644
--- a/src/ui/dialogs/ve.ui.DiffDialog.js
+++ b/src/ui/dialogs/ve.ui.DiffDialog.js
@@ -87,7 +87,9 @@
        // Parent method
        ve.ui.DiffDialog.parent.prototype.setDimensions.apply( this, arguments 
);
 
-       this.positionDiffElement();
+       if ( !this.positioning ) {
+               this.positionDiffElement();
+       }
 };
 
 /**
@@ -99,10 +101,12 @@
        var dialog = this;
        setTimeout( function () {
                dialog.withoutSizeTransitions( function () {
+                       dialog.positioning = true;
                        if ( dialog.diffElement && dialog.isVisible() ) {
                                dialog.diffElement.positionDescriptions();
                                dialog.updateSize();
                        }
+                       dialog.positioning = false;
                } );
        }, OO.ui.theme.getDialogTransitionDuration() );
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/386003
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I90fb54aad642e61cf17105a5c77d1e95cfe33b54
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits