[MediaWiki-commits] [Gerrit] mediawiki...QuickSurveys[master]: tests: Replace QUnit.expect with assert.expect

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/386209 )

Change subject: tests: Replace QUnit.expect with assert.expect
......................................................................


tests: Replace QUnit.expect with assert.expect

Change-Id: Ie786f3cd3faf0182c3964fac7de5000847b6ea07
---
M tests/qunit/ext.quicksurveys.lib/test_lib.js
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/qunit/ext.quicksurveys.lib/test_lib.js 
b/tests/qunit/ext.quicksurveys.lib/test_lib.js
index bef8312..b777e14 100644
--- a/tests/qunit/ext.quicksurveys.lib/test_lib.js
+++ b/tests/qunit/ext.quicksurveys.lib/test_lib.js
@@ -12,7 +12,7 @@
                }
        } );
 
-       QUnit.test( 'showSurvey: Placement (infobox)', 3, function ( assert ) {
+       QUnit.test( 'showSurvey: Placement (infobox)', function ( assert ) {
                var minervaTemplate = mw.template.get( 
'ext.quicksurveys.lib.tests', 'minerva-1.html' ),
                        $locationVector = mw.template.get( 
'ext.quicksurveys.lib.tests', 'vector-1.html' ).render(),
                        $locationMinerva = minervaTemplate.render(),
@@ -30,7 +30,7 @@
                        'Check on mobile page it is inserted in correct place 
(before infobox)' );
        } );
 
-       QUnit.test( 'showSurvey: Placement (image)', 3, function ( assert ) {
+       QUnit.test( 'showSurvey: Placement (image)', function ( assert ) {
                var template = mw.template.get( 'ext.quicksurveys.lib.tests', 
'minerva-2.html' ),
                        $locationVector = mw.template.get( 
'ext.quicksurveys.lib.tests', 'vector-2.html' ).render(),
                        $locationMinerva = template.render(),
@@ -49,7 +49,7 @@
                        'Check it is inserted in correct place (before image)' 
);
        } );
 
-       QUnit.test( 'showSurvey: Placement (no headings)', 6, function ( assert 
) {
+       QUnit.test( 'showSurvey: Placement (no headings)', function ( assert ) {
                var template = mw.template.get( 'ext.quicksurveys.lib.tests', 
'minerva-3.html' ),
                        $locationVector = mw.template.get( 
'ext.quicksurveys.lib.tests', 'vector-3.html' ).render(),
                        $locationMinerva = template.render(),
@@ -126,10 +126,10 @@
                        assert.ok( qSurveys.surveyMatchesPlatform( { platforms: 
test[0] }, 'stable' ) === test[2] );
                        assert.ok( qSurveys.surveyMatchesPlatform( { platforms: 
test[0] }, 'beta' ) === test[3] );
                } );
-               QUnit.expect( testCases.length * 3 );
+               assert.expect( testCases.length * 3 );
        } );
 
-       QUnit.test( 'showSurvey: Placement (plain)', 3, function ( assert ) {
+       QUnit.test( 'showSurvey: Placement (plain)', function ( assert ) {
                var template = mw.template.get( 'ext.quicksurveys.lib.tests', 
'minerva-4.html' ),
                        $locationVector = mw.template.get( 
'ext.quicksurveys.lib.tests', 'vector-4.html' ).render(),
                        $locationMinerva = template.render(),

-- 
To view, visit https://gerrit.wikimedia.org/r/386209
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie786f3cd3faf0182c3964fac7de5000847b6ea07
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/QuickSurveys
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits