DCausse has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/386088 )
Change subject: Hyperopt doesn't work with networkx >= 2.0
......................................................................
Hyperopt doesn't work with networkx >= 2.0
It doesn't say so in its packaging, but with
networkx >= 2.0 it will error out with:
assert order[-1] == expr
TypeError: 'generator' object has no attribute '__getitem__'
Help out hyperopt by limiting the version of
networkx supported by mjolnir.
Change-Id: I155f133a04724c9960e4e6c3387de543360e3dbd
---
M setup.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
DCausse: Verified; Looks good to me, approved
diff --git a/setup.py b/setup.py
index 524d18d..4456776 100644
--- a/setup.py
+++ b/setup.py
@@ -7,10 +7,12 @@
'clickmodels',
'requests',
'kafka',
+ 'hyperopt',
+ # hyperopt requires networkx < 2.0, but doesn't say so
+ 'networkx<2.0',
# pyspark requirements
'py4j',
'numpy',
- 'hyperopt',
]
test_requirements = [
--
To view, visit https://gerrit.wikimedia.org/r/386088
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I155f133a04724c9960e4e6c3387de543360e3dbd
Gerrit-PatchSet: 2
Gerrit-Project: search/MjoLniR
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: DCausse <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits