jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/386460 )
Change subject: There's only one refInRefProcessor
......................................................................
There's only one refInRefProcessor
* Avoid the unnecessary binding.
Change-Id: I80e558a86eb7197ce39a07062499ec58f170a3af
---
M lib/ext/Cite/index.js
1 file changed, 8 insertions(+), 10 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/ext/Cite/index.js b/lib/ext/Cite/index.js
index 61b3add..e54eb75 100644
--- a/lib/ext/Cite/index.js
+++ b/lib/ext/Cite/index.js
@@ -385,8 +385,10 @@
});
};
-References.prototype.extractRefFromNode = function(node, refsData,
- refInRefProcessor, referencesAboutId, referencesGroup,
nestedRefsHTML) {
+var _processRefs;
+
+References.prototype.extractRefFromNode = function(node, refsData, cite,
+ referencesAboutId, referencesGroup, nestedRefsHTML) {
var nestedInReferences = referencesAboutId !== undefined;
var dp = DU.getDataParsoid(node);
// SSS FIXME: Need to clarify semantics here.
@@ -407,7 +409,7 @@
if (dp.hasRefInRef) {
var html = DU.ppToDOM(content);
- refInRefProcessor(html);
+ _processRefs(cite, refsData, html);
content = DU.ppToXML(html, { innerXML: true });
}
@@ -637,9 +639,7 @@
* <references> <ref>foo</ref> </references>
* <references> <ref>bar</ref> </references>
* -------------------------------------------- */
-var _processRefs, _processRefsInReferences;
-
-_processRefsInReferences = function(cite, refsData, node, referencesId,
+var _processRefsInReferences = function(cite, refsData, node, referencesId,
referencesGroup, nestedRefsHTML) {
var child = node.firstChild;
while (child !== null) {
@@ -647,8 +647,7 @@
if (DU.isElt(child)) {
var typeOf = child.getAttribute('typeof');
if
((/(?:^|\s)mw:Extension\/ref\/Marker(?=$|\s)/).test(typeOf)) {
- cite.references.extractRefFromNode(child,
refsData,
- _processRefs.bind(null, cite, refsData),
+ cite.references.extractRefFromNode(child,
refsData, cite,
referencesId, referencesGroup,
nestedRefsHTML);
} else if (child.hasChildNodes()) {
_processRefsInReferences(cite, refsData,
@@ -667,8 +666,7 @@
if (DU.isElt(child)) {
var typeOf = child.getAttribute('typeof');
if
((/(?:^|\s)mw:Extension\/ref\/Marker(?=$|\s)/).test(typeOf)) {
- cite.references.extractRefFromNode(child,
refsData,
- _processRefs.bind(null, cite,
refsData));
+ cite.references.extractRefFromNode(child,
refsData, cite);
} else if
((/(?:^|\s)mw:Extension\/references(?=$|\s)/).test(typeOf)) {
var referencesId = child.getAttribute("about");
var referencesGroup =
DU.getDataParsoid(child).group;
--
To view, visit https://gerrit.wikimedia.org/r/386460
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80e558a86eb7197ce39a07062499ec58f170a3af
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <[email protected]>
Gerrit-Reviewer: Arlolra <[email protected]>
Gerrit-Reviewer: C. Scott Ananian <[email protected]>
Gerrit-Reviewer: Sbailey <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
