jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/386556 )
Change subject: Cosmetic changes to CargoGalleryFormat.php ...................................................................... Cosmetic changes to CargoGalleryFormat.php Change-Id: Id5caa9fde4d33d53ee4e9b649d62269001fb43c3 --- M formats/CargoGalleryFormat.php 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Yaron Koren: Looks good to me, approved jenkins-bot: Verified diff --git a/formats/CargoGalleryFormat.php b/formats/CargoGalleryFormat.php index e1c741b..bde95e9 100644 --- a/formats/CargoGalleryFormat.php +++ b/formats/CargoGalleryFormat.php @@ -2,15 +2,18 @@ /** * @author Yaron Koren * @ingroup Cargo + * + * Defines the 'gallery' format, which matches the output of MediaWiki's + * <gallery> tag. */ class CargoGalleryFormat extends CargoDisplayFormat { function allowedParameters() { - return array( 'mode','show bytes','show filename','per row','image width','image height' ); + return array( 'mode', 'show bytes', 'show filename', 'per row', 'image width', 'image height' ); } - function getFileTitles( $valuesTable, $fieldDescriptions, $captionField, $altField, $linkField ) { + function getFileTitles( $valuesTable, $fieldDescriptions, $captionField, $altField, $linkField ) { $fileField = null; foreach ( $fieldDescriptions as $field => $fieldDesc ) { if ( $fieldDesc->mType == 'File' ) { @@ -39,12 +42,12 @@ 'caption' => $caption, 'alt' => $alt, 'link' => $link - ); + ); } } $files = array(); - foreach( $fileNames as $f ) { + foreach ( $fileNames as $f ) { if ( $usingPageName ) { $title = Title::newFromText( $f['title'] ); if ( $title == null || $title->getNamespace() != NS_FILE ) { -- To view, visit https://gerrit.wikimedia.org/r/386556 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5caa9fde4d33d53ee4e9b649d62269001fb43c3 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Cargo Gerrit-Branch: master Gerrit-Owner: Yaron Koren <yaro...@gmail.com> Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits