jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/386542 )
Change subject: EmptyInterwikiResolver doesn't fully implement InterwikiResolver ...................................................................... EmptyInterwikiResolver doesn't fully implement InterwikiResolver Not sure how this made it through CI, but tests no longer pass because this interface isn't fuly implemented. Update the implementation for recent changes. Change-Id: I922aa64a5394b335aa28d2d112d72ae9457460e4 --- M includes/EmptyInterwikiResolver.php 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Smalyshev: Looks good to me, approved Cindy-the-browser-test-bot: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/includes/EmptyInterwikiResolver.php b/includes/EmptyInterwikiResolver.php index 89d4623..66b49b7 100644 --- a/includes/EmptyInterwikiResolver.php +++ b/includes/EmptyInterwikiResolver.php @@ -11,6 +11,13 @@ } /** + * @return SearchConfig[] configs of sister projects indexed by interwiki prefix + */ + public function getSisterProjectConfigs() { + return []; + } + + /** * @param string $wikiId * @return string|null the interwiki identified for this $wikiId or null if none found */ @@ -25,4 +32,12 @@ public function getSameProjectWikiByLang( $lang ) { return []; } + + /** + * @param string $lang + * @return SearchConfig[] zero or one element array: [] or [ interwiki -> SearchConfig ] + */ + public function getSameProjectConfigByLang( $lang ) { + return []; + } } -- To view, visit https://gerrit.wikimedia.org/r/386542 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I922aa64a5394b335aa28d2d112d72ae9457460e4 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/CirrusSearch Gerrit-Branch: master Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org> Gerrit-Reviewer: Cindy-the-browser-test-bot <bernhardsone...@gmail.com> Gerrit-Reviewer: DCausse <dcau...@wikimedia.org> Gerrit-Reviewer: Gehel <guillaume.leder...@wikimedia.org> Gerrit-Reviewer: Smalyshev <smalys...@wikimedia.org> Gerrit-Reviewer: Tjones <tjo...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits