jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/386431 )
Change subject: build: Bump various devDependencies to latest
......................................................................
build: Bump various devDependencies to latest
eslint-config-wikimedia 0.4.0 → 0.5.0
grunt-banana-checker 0.5.0 → 0.6.0
grunt-eslint 19.0.0 → 20.1.0
grunt-stylelint 0.6.0 → 0.8.0
Change-Id: Ia01949112243c5a496896c0a3a5eda261e0f66bd
---
M modules/jquery.codeEditor.js
M package.json
2 files changed, 18 insertions(+), 18 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/jquery.codeEditor.js b/modules/jquery.codeEditor.js
index 91cfe16..ba4058e 100644
--- a/modules/jquery.codeEditor.js
+++ b/modules/jquery.codeEditor.js
@@ -330,20 +330,20 @@
api.abort();
api.saveOption( 'usecodeeditor', prefValue ? 1
: 0 )
- .fail( function ( code, result ) {
- var message;
+ .fail( function ( code, result ) {
+ var message;
- if ( code === 'http' &&
result.textStatus === 'abort' ) {
- // Request was aborted. Ignore
error
- return;
- }
+ if ( code === 'http' &&
result.textStatus === 'abort' ) {
+ // Request was aborted.
Ignore error
+ return;
+ }
- message = 'Failed to set code editor
preference: ' + code;
- if ( result.error && result.error.info
) {
- message += '\n' +
result.error.info;
- }
- mw.log.warn( message );
- } );
+ message = 'Failed to set code
editor preference: ' + code;
+ if ( result.error &&
result.error.info ) {
+ message += '\n' +
result.error.info;
+ }
+ mw.log.warn( message );
+ } );
},
/**
* Sets up the iframe in place of the textarea to allow
more advanced operations
@@ -381,9 +381,9 @@
box.textSelection( 'register',
textSelectionFn );
// Disable some annoying commands
-
context.codeEditor.commands.removeCommand( 'replace' ); // ctrl+R
+
context.codeEditor.commands.removeCommand( 'replace' ); // ctrl+R
context.codeEditor.commands.removeCommand( 'transposeletters' ); // ctrl+T
-
context.codeEditor.commands.removeCommand( 'gotoline' ); // ctrl+L
+
context.codeEditor.commands.removeCommand( 'gotoline' ); // ctrl+L
context.codeEditor.setReadOnly(
box.prop( 'readonly' ) );
context.codeEditor.setShowInvisibles(
context.showInvisibleChars );
diff --git a/package.json b/package.json
index 0e4e1ab..1f0d3cd 100644
--- a/package.json
+++ b/package.json
@@ -7,12 +7,12 @@
"test": "grunt test"
},
"devDependencies": {
- "eslint-config-wikimedia": "0.4.0",
+ "eslint-config-wikimedia": "0.5.0",
"grunt": "1.0.1",
- "grunt-banana-checker": "0.5.0",
- "grunt-eslint": "19.0.0",
+ "grunt-banana-checker": "0.6.0",
+ "grunt-eslint": "20.1.0",
"grunt-jsonlint": "1.1.0",
- "grunt-stylelint": "0.6.0",
+ "grunt-stylelint": "0.8.0",
"stylelint": "7.8.0",
"stylelint-config-wikimedia": "0.4.1"
}
--
To view, visit https://gerrit.wikimedia.org/r/386431
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia01949112243c5a496896c0a3a5eda261e0f66bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
