jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/386631 )

Change subject: Made Special:DeleteCargoTable unlisted
......................................................................


Made Special:DeleteCargoTable unlisted

Change-Id: I82abf11c69a60ef709971bf246e47355ad08ea83
---
M specials/CargoDeleteTable.php
1 file changed, 1 insertion(+), 13 deletions(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/specials/CargoDeleteTable.php b/specials/CargoDeleteTable.php
index 22965e3..4ec9b0a 100644
--- a/specials/CargoDeleteTable.php
+++ b/specials/CargoDeleteTable.php
@@ -7,14 +7,11 @@
  * CargoDeleteTable.php, and the wiki page is Special:DeleteCargoTable...
  * sorry for the confusion!
  *
- *
  * @author Yaron Koren
  * @ingroup Cargo
- * @todo This should really inherit from UnlistedSpecialPage and there should 
be a link from
- * Special:CargoTables to delete that table.
  */
 
-class CargoDeleteCargoTable extends SpecialPage {
+class CargoDeleteCargoTable extends UnlistedSpecialPage {
 
        function __construct() {
                parent::__construct( 'DeleteCargoTable', 'deletecargodata' );
@@ -101,14 +98,5 @@
                $out->addHTML( $text );
 
                return true;
-       }
-
-       /**
-        * @todo Should be unlisted
-        *
-        * @return string
-        */
-       protected function getGroupName() {
-               return 'cargo';
        }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/386631
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I82abf11c69a60ef709971bf246e47355ad08ea83
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to