BBlack has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/381017 )
Change subject: Global: runtime disable ethernet flow on fresh install
......................................................................
Global: runtime disable ethernet flow on fresh install
This adds runtime execution of the ethtool command to disable flow
control when the interfaces file is first modified for it.
Assuming the previous change is applied fully on the fleet first,
this should not cause runtime execution on existing hosts, but
puts it in place for future fresh installs on their initial
puppetization.
Change-Id: I1dfc4ee6b9781bb32cae025a2d4773d9871ddde0
---
M modules/interface/manifests/noflow.pp
1 file changed, 12 insertions(+), 1 deletion(-)
Approvals:
BBlack: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/interface/manifests/noflow.pp
b/modules/interface/manifests/noflow.pp
index 7a66b1c..8751ef7 100644
--- a/modules/interface/manifests/noflow.pp
+++ b/modules/interface/manifests/noflow.pp
@@ -1,6 +1,8 @@
# Definition: interface::noflow
#
-# Disable ethernet flow control at boot time via up-commands.
+# Disable ethernet flow control at boot time via up-commands, and also at
+# runtime when first adding to boot time up-commands, so that it's applied on
+# freshly-installed hosts without another reboot required.
#
# Parameters:
# - $interface=$name:
@@ -15,4 +17,13 @@
interface => $interface,
command => $cmd,
}
+
+ # Exec immediately at runtime when first added to interfaces file
+ exec { "noflow-${interface}":
+ path => '/usr/bin:/usr/sbin:/bin:/sbin',
+ command => $cmd,
+ require => Package['ethtool'],
+ subscribe => Augeas["${interface}_noflow-${interface}"],
+ refreshonly => true,
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/381017
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1dfc4ee6b9781bb32cae025a2d4773d9871ddde0
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <bbl...@wikimedia.org>
Gerrit-Reviewer: BBlack <bbl...@wikimedia.org>
Gerrit-Reviewer: Faidon Liambotis <fai...@wikimedia.org>
Gerrit-Reviewer: Mark Bergsma <m...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
