Chad has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386689 )

Change subject: Group XMP parse failures by exception message
......................................................................

Group XMP parse failures by exception message

I *think* this will work since we pass the full exception object to
the log handler. It breaks exception.* into fields into the final
logstash entries, so maybe we can do that here too and save a param?

Change-Id: I2bba40ded5c90f2e19a32bb5540e3c441b605da6
---
M includes/libs/xmp/XMP.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/89/386689/1

diff --git a/includes/libs/xmp/XMP.php b/includes/libs/xmp/XMP.php
index c46acc6..d8c98d3 100644
--- a/includes/libs/xmp/XMP.php
+++ b/includes/libs/xmp/XMP.php
@@ -388,7 +388,7 @@
                        }
                } catch ( Exception $e ) {
                        $this->logger->warning(
-                               '{method} Exception caught while parsing: ' . 
$e->getMessage(),
+                               '{method} Exception caught while parsing: 
{exception.message}',
                                [
                                        'method' => __METHOD__,
                                        'exception' => $e,

-- 
To view, visit https://gerrit.wikimedia.org/r/386689
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2bba40ded5c90f2e19a32bb5540e3c441b605da6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <ch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to