Bearloga has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385014 )

Change subject: Annotation of mw.track bug fix
......................................................................


Annotation of mw.track bug fix

Bug: T178097
Change-Id: I720a8ec47c0a2d86480f3b7c97880ee890a53c03
---
M modules/mobile_web/events.R
M tab_documentation/mobile_events.md
2 files changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Bearloga: Verified; Looks good to me, approved



diff --git a/modules/mobile_web/events.R b/modules/mobile_web/events.R
index 3e0125a..8e044cc 100644
--- a/modules/mobile_web/events.R
+++ b/modules/mobile_web/events.R
@@ -40,12 +40,14 @@
     polloi::make_dygraph(xlab = "Date", ylab = "Events", title = "Mobile 
search events, by day") %>%
     dyRangeSelector %>%
     dyEvent(as.Date("2017-01-01"), "R (reportupdater)", labelLoc = "bottom") 
%>%
-    dyEvent(as.Date("2017-03-29"), "H (new header)", labelLoc = "bottom")
+    dyEvent(as.Date("2017-03-29"), "H (new header)", labelLoc = "bottom") %>%
+    dyEvent(as.Date("2017-09-28"), "B (mw.track bug)", labelLoc = "bottom")
 })
 
 output$mobile_session_plot <- renderDygraph({
   mobile_session %>%
     polloi::smoother(smooth_level = 
polloi::smooth_switch(input$smoothing_global, input$smoothing_mobile_event)) %>%
     polloi::make_dygraph(xlab = "Date", ylab = "Events", title = "Mobile user 
sessions, by volume") %>%
-    dyRangeSelector
+    dyRangeSelector %>%
+    dyEvent(as.Date("2017-09-28"), "B (mw.track bug)", labelLoc = "bottom")
 })
diff --git a/tab_documentation/mobile_events.md 
b/tab_documentation/mobile_events.md
index c8a029a..e362462 100644
--- a/tab_documentation/mobile_events.md
+++ b/tab_documentation/mobile_events.md
@@ -26,6 +26,7 @@
 * Between 5 May and 6 May 2015, approximately 40% of incoming EventLogging 
data was lost due to a wider EventLogging outage. You can read more about the 
outage 
[here](https://wikitech.wikimedia.org/wiki/Incident_documentation/20150506-EventLogging).
 * '__R__': on 2017-01-01 we started calculating all of Discovery's metrics 
using a new version of [our data retrieval and processing 
codebase](https://phabricator.wikimedia.org/diffusion/WDGO/) that we migrated 
to [Wikimedia Analytics](https://www.mediawiki.org/wiki/Analytics)' 
[Reportupdater 
infrastructure](https://wikitech.wikimedia.org/wiki/Analytics/Reportupdater). 
See [T150915](https://phabricator.wikimedia.org/T150915) for more details.
 * '__H__': on 2017-03-29 we deployed the new mobile header treatment 
(including the search box) which may result in the decrease of search. See 
[T176464](https://phabricator.wikimedia.org/T176464) for more information.
+* '__B__': on 2017-09-28 a bug in 
[`mw.track`](https://www.mediawiki.org/wiki/ResourceLoader/Core_modules#mw.track)
 was fixed. Before 2017-09-28, if events are logged via 
[`mw.track`](https://www.mediawiki.org/wiki/ResourceLoader/Core_modules#mw.track),
 only events tracked during the first pageview of a user's session were logged. 
See [T175918](https://phabricator.wikimedia.org/T175918) for more details.
 
 Questions, bug reports, and feature suggestions
 ------

-- 
To view, visit https://gerrit.wikimedia.org/r/385014
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I720a8ec47c0a2d86480f3b7c97880ee890a53c03
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/discovery/rainbow
Gerrit-Branch: develop
Gerrit-Owner: Chelsyx <c...@wikimedia.org>
Gerrit-Reviewer: Bearloga <mpo...@wikimedia.org>
Gerrit-Reviewer: Chelsyx <c...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to