BBlack has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/379801 )

Change subject: Caches: Disable LRO
......................................................................


Caches: Disable LRO

Change-Id: If88406ffc061eedab624533275493b181fff3fb2
---
M modules/cacheproxy/manifests/performance.pp
1 file changed, 12 insertions(+), 3 deletions(-)

Approvals:
  BBlack: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/cacheproxy/manifests/performance.pp 
b/modules/cacheproxy/manifests/performance.pp
index 699202a..92918da 100644
--- a/modules/cacheproxy/manifests/performance.pp
+++ b/modules/cacheproxy/manifests/performance.pp
@@ -5,6 +5,8 @@
 # tweaks to support heavy load/traffic.
 class cacheproxy::performance {
 
+    $iface_primary = $facts['interface_primary']
+
     # Bump min_free_kbytes to ensure network buffers are available quickly
     #   without having to evict cache on the spot
     vm::min_free_kbytes { 'cache':
@@ -29,21 +31,28 @@
 
     # Larger TX queue len for 10Gbps+
     interface::txqueuelen { $name:
-        interface => $facts['interface_primary'],
+        interface => $iface_primary,
         len       => 10000,
     }
 
     # Max for bnx2x/BCM57800, seems to eliminate the spurious rx drops under 
heavy traffic
     interface::ring { "${name} rxring":
-        interface => $facts['interface_primary'],
+        interface => $iface_primary,
         setting   => 'rx',
         value     => 4078,
+    }
+
+    # Disable LRO to avoid merging important headers for flow control and such
+    interface::offload { "${iface_primary}-lro":
+        interface => $iface_primary,
+        setting   => 'lro',
+        value     => 'off',
     }
 
     # RPS/RSS to spread network i/o evenly.  Note this enables FQ as well,
     # which must be enabled before turning on BBR congestion control below
     interface::rps { 'primary':
-        interface => $facts['interface_primary'],
+        interface => $iface_primary,
         qdisc     => 'fq flow_limit 300 buckets 8192 maxrate 1gbit',
         before    => Sysctl::Parameters['cache proxy network tuning'],
     }

-- 
To view, visit https://gerrit.wikimedia.org/r/379801
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If88406ffc061eedab624533275493b181fff3fb2
Gerrit-PatchSet: 11
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <bbl...@wikimedia.org>
Gerrit-Reviewer: BBlack <bbl...@wikimedia.org>
Gerrit-Reviewer: Ema <e...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to