Daniel Werner has uploaded a new change for review.
https://gerrit.wikimedia.org/r/55881
Change subject: some minor cleanup in snakview related files
......................................................................
some minor cleanup in snakview related files
Also fixes a problem with function signature in
snakview.variations.newFromSnakType
Change-Id: I6967f3668611705062fa373ddf2fe99a3b298dff
---
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
2 files changed, 10 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/81/55881/1
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
index d270b5a..90f2887 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
@@ -15,9 +15,9 @@
* View for displaying and editing Wikibase Snaks.
* @since 0.3
*
- * @option value {Object|wb.Snak|null} The snak this view should represent. If
omitted, an empty
- * view will be served, ready to take some input by the user. The
value can be overwritten
- * later, by using the value() or snak() functions.
+ * @option value {Object|wb.Snak|null} The snak this view should represent
initially. If omitted,
+ * an empty view will be served, ready to take some input by the user.
The value can also be
+ * overwritten later, by using the value() or snak() functions.
* Default: { property: null, snaktype: wb.PropertyValueSnak.TYPE }
*
* @option locked {Object|boolean} Key-value pairs determining which snakview
elements to lock. May
@@ -96,7 +96,9 @@
/**
* Variation object responsible for presenting the essential parts of a
certain kind of Snak.
- * @type jQuery.wikibase.snakview.variations.Variation
+ * Can be null if a unsupported Snak Type is represented by the
snakview. In this case the
+ * snakview won't be able to display the Snak but display an
appropriate message instead.
+ * @type jQuery.wikibase.snakview.variations.Variation|null
*/
_variation: null,
@@ -846,7 +848,7 @@
},
/**
- * Marks the Snak view disabled and triggers re-drawing the Snak view.
+ * Marks the Snak view disabled and triggers re-drawing it.
* Since the visual state should be managed completely by the draw
method, toggling the css
* classes is done in draw() by issuing a call to $.Widget.option().
* @see jQuery.Widget.disable
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
index 3464ead..953fc6d 100644
---
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
+++
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
@@ -115,17 +115,18 @@
* @since 0.4
*
* @param {String} snakType
+ * @param {jQuery.wikibase.snakview.ViewState} viewState
* @param {jQuery} $variationViewPort
* @return jQuery.wikibase.snakview.variations.Variation|null
*/
- newFromSnakType: function( snakType, $variationViewPort ) {
+ newFromSnakType: function( snakType, viewState,
$variationViewPort ) {
if( typeof snakType !== 'string' ) {
throw new Error( 'Snak type required for
choosing a suitable variation' );
}
if( !SELF.hasVariation( snakType ) ) {
return null;
}
- return new ( SELF.getVariation( snakType ) )(
$variationViewPort );
+ return new ( SELF.getVariation( snakType ) )(
viewState, $variationViewPort );
}
};
--
To view, visit https://gerrit.wikimedia.org/r/55881
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6967f3668611705062fa373ddf2fe99a3b298dff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
