Petar.petkovic has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386953 )

Change subject: Show noscroll margin only on bigger screens
......................................................................

Show noscroll margin only on bigger screens

* Don't add margin to the right for screen sizes below 700px
when noscroll is activated on body tag. Additional margin is added
to fill the space left by scrollbar disappearing, but narrow screens
would arguably only be used on mobile, where scrollbar doesn't take space.

Change-Id: I7830af6124a0a829aaf3e466568623a68f8fcda9
---
M modules/widgets/overlay/ext.cx.overlay.less
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/53/386953/1

diff --git a/modules/widgets/overlay/ext.cx.overlay.less 
b/modules/widgets/overlay/ext.cx.overlay.less
index ed3be14..34317d0 100644
--- a/modules/widgets/overlay/ext.cx.overlay.less
+++ b/modules/widgets/overlay/ext.cx.overlay.less
@@ -1,3 +1,5 @@
+@import '../../widgets/common/ext.cx.common.less';
+
 .cx-overlay {
        background-color: #fff;
        position: fixed;
@@ -15,6 +17,8 @@
 
 body.cx-noscroll {
        overflow: hidden;
-       // Avoid content jump when we hide the scrollbar.
-       margin-right: 15px;
+       // Avoid content jump when we hide the scrollbar on medium and large 
screens
+       @media only screen and ( min-width: @narrow ) {
+               margin-right: 15px;
+       }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/386953
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7830af6124a0a829aaf3e466568623a68f8fcda9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Petar.petkovic <ppetko...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to