Liangent has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/55895


Change subject: Use MessageCache::getMsgFromNamespace() to fetch conversion 
tables.
......................................................................

Use MessageCache::getMsgFromNamespace() to fetch conversion tables.

After Iaaf6cceb, MessageCache::get() goes through the fallback chain,
which is unwanted for conversion tables (for example, we don't want
zh-hans table for zh, where zh means "no conversion"). Since the only
needed feature is to fetch text from MediaWiki namespace (conversion
tables in code are stored somewhere else), it is now changed to use
MessageCache::getMsgFromNamespace() instead to avoid fallbacks.

Change-Id: I46e0be31c9c0fe0a6e4923fc1aff0fbbadbf1d67
---
M languages/LanguageConverter.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/95/55895/1

diff --git a/languages/LanguageConverter.php b/languages/LanguageConverter.php
index 43afe65..e36c085 100644
--- a/languages/LanguageConverter.php
+++ b/languages/LanguageConverter.php
@@ -941,7 +941,7 @@
                $parsed[$key] = true;
 
                if ( $subpage === '' ) {
-                       $txt = MessageCache::singleton()->get( 
'conversiontable', true, $code );
+                       $txt = MessageCache::singleton()->getMsgFromNamespace( 
$key, $code );
                } else {
                        $txt = false;
                        $title = Title::makeTitleSafe( NS_MEDIAWIKI, $key );

-- 
To view, visit https://gerrit.wikimedia.org/r/55895
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46e0be31c9c0fe0a6e4923fc1aff0fbbadbf1d67
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Liangent <liang...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to