jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/387233 )
Change subject: Chore: rename data-clients to http
......................................................................
Chore: rename data-clients to http
Rename "data clients" to "HTTP clients":
- Move src/common/data-clients to src/common/http.
- Rename *-data-client.ts to *-http-client.ts.
"HTTP client" seems less ambiguous than "data client" where "data" could
refer to many things.
Change-Id: Ibea658089d70a2b5f4625137f2cc734d47d12d34
---
R src/common/http/http-response.ts
R src/common/http/page-http-client.ts
R src/common/http/page-redirect.ts
R src/common/http/page-summary-http-client.ts
R src/common/http/restbase-title-encoder.test.ts
R src/common/http/restbase-title-encoder.ts
M src/common/pages/summary.tsx
M src/common/pages/wiki.tsx
M src/common/routers/route.ts
M src/common/routers/router.ts
10 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Niedzielski: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/common/data-clients/http-response.ts
b/src/common/http/http-response.ts
similarity index 100%
rename from src/common/data-clients/http-response.ts
rename to src/common/http/http-response.ts
diff --git a/src/common/data-clients/page-data-client.ts
b/src/common/http/page-http-client.ts
similarity index 100%
rename from src/common/data-clients/page-data-client.ts
rename to src/common/http/page-http-client.ts
diff --git a/src/common/data-clients/page-redirect.ts
b/src/common/http/page-redirect.ts
similarity index 100%
rename from src/common/data-clients/page-redirect.ts
rename to src/common/http/page-redirect.ts
diff --git a/src/common/data-clients/page-summary-data-client.ts
b/src/common/http/page-summary-http-client.ts
similarity index 100%
rename from src/common/data-clients/page-summary-data-client.ts
rename to src/common/http/page-summary-http-client.ts
diff --git a/src/common/data-clients/restbase-title-encoder.test.ts
b/src/common/http/restbase-title-encoder.test.ts
similarity index 100%
rename from src/common/data-clients/restbase-title-encoder.test.ts
rename to src/common/http/restbase-title-encoder.test.ts
diff --git a/src/common/data-clients/restbase-title-encoder.ts
b/src/common/http/restbase-title-encoder.ts
similarity index 100%
rename from src/common/data-clients/restbase-title-encoder.ts
rename to src/common/http/restbase-title-encoder.ts
diff --git a/src/common/pages/summary.tsx b/src/common/pages/summary.tsx
index f2ef0f1..adc5012 100644
--- a/src/common/pages/summary.tsx
+++ b/src/common/pages/summary.tsx
@@ -5,10 +5,10 @@
import { PageTitleID, PageTitlePath } from "../models/page/title";
import Page from "../components/page/page";
import { RouteParams } from "../routers/route";
-import { request } from "../data-clients/page-summary-data-client";
+import { request } from "../http/page-summary-http-client";
import ContentHeader from "../components/content-header/content-header";
import ContentFooter from "../components/content-footer/content-footer";
-import HttpResponse from "../data-clients/http-response";
+import HttpResponse from "../http/http-response";
interface PageParams extends RouteParams {
/**
diff --git a/src/common/pages/wiki.tsx b/src/common/pages/wiki.tsx
index 71141f7..602b18b 100644
--- a/src/common/pages/wiki.tsx
+++ b/src/common/pages/wiki.tsx
@@ -5,10 +5,10 @@
import { PageTitleID, PageTitlePath } from "../models/page/title";
import Page from "../components/page/page";
import { RouteParams } from "../routers/route";
-import { requestPage } from "../data-clients/page-data-client";
+import { requestPage } from "../http/page-http-client";
import ContentFooter from "../components/content-footer/content-footer";
import ContentPage from "../components/content-page/content-page";
-import HttpResponse from "../data-clients/http-response";
+import HttpResponse from "../http/http-response";
interface PageParams extends RouteParams {
/**
diff --git a/src/common/routers/route.ts b/src/common/routers/route.ts
index a402259..9653621 100644
--- a/src/common/routers/route.ts
+++ b/src/common/routers/route.ts
@@ -1,6 +1,6 @@
import * as pathToRegExp from "path-to-regexp";
import { AnyComponent } from "../components/preact-utils";
-import HttpResponse from "../data-clients/http-response";
+import HttpResponse from "../http/http-response";
/**
* A map of path-to-regexp router path names to matches. The keys must match
diff --git a/src/common/routers/router.ts b/src/common/routers/router.ts
index cc5e4f8..79d5b4b 100644
--- a/src/common/routers/router.ts
+++ b/src/common/routers/router.ts
@@ -5,7 +5,7 @@
Route,
RouteParams
} from "../../common/routers/route";
-import HttpResponse from "../data-clients/http-response";
+import HttpResponse from "../http/http-response";
export interface RouteResponse<Props> {
chunkName: string;
--
To view, visit https://gerrit.wikimedia.org/r/387233
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibea658089d70a2b5f4625137f2cc734d47d12d34
Gerrit-PatchSet: 2
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
