Bmansurov has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387871 )
Change subject: Escape article title before sending it to RESTBase ...................................................................... Escape article title before sending it to RESTBase The change takes care of article titles such as https://en.wikipedia.org/wiki/CP/M-86 before sending them to RESTBase. I've noted to add tests to cover this and other edge cases in follow up patches where I've already added tests. Bug: T176627 Change-Id: I1d32590d2ba5943ef2899cd1be60f0027326fd6c --- M routes/html2pdf-v1.js M test/features/v1/html2pdf.js 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/chromium-render refs/changes/71/387871/1 diff --git a/routes/html2pdf-v1.js b/routes/html2pdf-v1.js index c50f14d..35bb7cc 100644 --- a/routes/html2pdf-v1.js +++ b/routes/html2pdf-v1.js @@ -65,7 +65,7 @@ request: { params: { domain: req.params.domain, - path: `page/html/${req.params.title}` + path: `page/html/${encodeURIComponent(req.params.title)}` } } }); diff --git a/test/features/v1/html2pdf.js b/test/features/v1/html2pdf.js index 958c6c8..4680f25 100644 --- a/test/features/v1/html2pdf.js +++ b/test/features/v1/html2pdf.js @@ -10,7 +10,7 @@ it('should return a letter-sized PDF', function() { return preq.get( - server.config.uri + 'en.wikipedia.org/v1/pdf/Letter' + server.config.uri + 'en.wikipedia.org/v1/pdf/CP%2FM-86/letter' ) .then(function(res) { assert.status(res, 200); -- To view, visit https://gerrit.wikimedia.org/r/387871 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1d32590d2ba5943ef2899cd1be60f0027326fd6c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/services/chromium-render Gerrit-Branch: master Gerrit-Owner: Bmansurov <bmansu...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
