Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388083 )
Change subject: Event name has changed ...................................................................... Event name has changed The beta opt in panel since the Minerva/MobileFrontend split and follow up changes can now show in non-Minerva skins. the name now reflects where the track event is triggered - inside MobileFrontend Bug: T179447 Change-Id: Iba87d404ac710e613f61b4ff9e779e89d7324bf7 --- M resources/ext.quicksurveys.init/init.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuickSurveys refs/changes/83/388083/1 diff --git a/resources/ext.quicksurveys.init/init.js b/resources/ext.quicksurveys.init/init.js index e95914d..8085bd8 100644 --- a/resources/ext.quicksurveys.init/init.js +++ b/resources/ext.quicksurveys.init/init.js @@ -19,7 +19,7 @@ // make sure the beta opt-in panel is not shown in Minerva if ( mw.config.get( 'skin' ) === 'minerva' ) { - mw.trackSubscribe( 'minerva.betaoptin', function ( topic, data ) { + mw.trackSubscribe( 'mobile.betaoptin', function ( topic, data ) { if ( data.isPanelShown === false ) { mw.extQuickSurveys.showSurvey( $bodyContent, isMobileLayout ); } -- To view, visit https://gerrit.wikimedia.org/r/388083 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iba87d404ac710e613f61b4ff9e779e89d7324bf7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/QuickSurveys Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits