Dzahn has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/388424 )
Change subject: gerrit: fix HTTPS monitoring, use service IP
......................................................................
gerrit: fix HTTPS monitoring, use service IP
Since I54b26eb1662e3fa68b1fc Gerrit isn't listening
on all interfaces anymore but only on the service IP as it
should.
This means the monitoring check for HTTPS needs to be adjusted.
The current command was using the $HOSTADDRESS$ variable in Icinga
which is the server IP, not the service IP.
Instead we need to use a different check command that doesn't use
$HOSTADDRESS$ but only a custom hostname as argument.
"check_ssl_on_host_port_letsencrypt" exists already and expects
3 args, --cn, -H and -p. --cn and -H are simply the same service name
now.
Change-Id: I4252d4f52d46c596b7d07727844afda6494094e3
---
M modules/gerrit/manifests/proxy.pp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/modules/gerrit/manifests/proxy.pp
b/modules/gerrit/manifests/proxy.pp
index 7016cc3..7c1a041 100644
--- a/modules/gerrit/manifests/proxy.pp
+++ b/modules/gerrit/manifests/proxy.pp
@@ -22,7 +22,7 @@
monitoring::service { 'https':
description => 'HTTPS',
- check_command => "check_ssl_http_letsencrypt!${tls_host}",
+ check_command =>
"check_ssl_on_host_port_letsencrypt!${tls_host}!${tls_host}!443",
contact_group => 'admins,gerrit',
}
--
To view, visit https://gerrit.wikimedia.org/r/388424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4252d4f52d46c596b7d07727844afda6494094e3
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: Paladox <thomasmulhall...@yahoo.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
