Hello Aaron Schulz, BryanDavis,

I'd like you to do a code review.  Please visit

    https://gerrit.wikimedia.org/r/388485

to review the following change.


Change subject: Group lock failed messages in mysql db driver
......................................................................

Group lock failed messages in mysql db driver

Change-Id: Ia8c993a3c405c37200c6c1a0dbe6b12726def7c1
---
M includes/libs/rdbms/database/DatabaseMysqlBase.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/85/388485/1

diff --git a/includes/libs/rdbms/database/DatabaseMysqlBase.php 
b/includes/libs/rdbms/database/DatabaseMysqlBase.php
index 5312a3d..e0ff475 100644
--- a/includes/libs/rdbms/database/DatabaseMysqlBase.php
+++ b/includes/libs/rdbms/database/DatabaseMysqlBase.php
@@ -1044,7 +1044,8 @@
                        return true;
                }
 
-               $this->queryLogger->warning( __METHOD__ . " failed to acquire 
lock '$lockName'\n" );
+               $this->queryLogger->warning( __METHOD__ . " failed to acquire 
lock '{lockname}'",
+                       [ 'lockname' => $lockName ] );
 
                return false;
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/388485
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8c993a3c405c37200c6c1a0dbe6b12726def7c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to