jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/386829 )
Change subject: Add missing return true to AddUsagesForPageJob ...................................................................... Add missing return true to AddUsagesForPageJob Bug: T178997 Change-Id: I6ec6985150557e99449e53a44cee72adb9fcdb77 --- M client/includes/Store/AddUsagesForPageJob.php 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/client/includes/Store/AddUsagesForPageJob.php b/client/includes/Store/AddUsagesForPageJob.php index e1467ff..34d3bcf 100644 --- a/client/includes/Store/AddUsagesForPageJob.php +++ b/client/includes/Store/AddUsagesForPageJob.php @@ -126,15 +126,17 @@ } /** - * Call UsageUpdater::addUsagesForPage + * @see Job::run * - * @return bool Success + * @return bool */ public function run() { $this->usageUpdater->addUsagesForPage( $this->pageId, $this->getUsages() ); + + return true; } } -- To view, visit https://gerrit.wikimedia.org/r/386829 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ec6985150557e99449e53a44cee72adb9fcdb77 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.kr...@wikimedia.de> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: Lucas Werkmeister (WMDE) <lucas.werkmeis...@wikimedia.de> Gerrit-Reviewer: Ppchelko <ppche...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits