Samwilson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/389660 )

Change subject: Make it possible to subclass SpecialPreferences
......................................................................

Make it possible to subclass SpecialPreferences

This updates the constructor with all of its arguments,
and makes a method protected rather than private.

Change-Id: I390e9d46fd2b8d4d8a1f9fd250c964a696b48244
---
M includes/specials/SpecialPreferences.php
1 file changed, 10 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/60/389660/1

diff --git a/includes/specials/SpecialPreferences.php 
b/includes/specials/SpecialPreferences.php
index 7c55e5c..f31bacc 100644
--- a/includes/specials/SpecialPreferences.php
+++ b/includes/specials/SpecialPreferences.php
@@ -27,8 +27,15 @@
  * @ingroup SpecialPage
  */
 class SpecialPreferences extends SpecialPage {
-       function __construct() {
-               parent::__construct( 'Preferences' );
+
+       /**
+        * @inheritDoc
+        */
+       public function __construct(
+               $name = 'Preferences', $restriction = '', $listed = true,
+               $function = false, $file = '', $includable = false
+       ) {
+               parent::__construct( $name, $restriction, $listed, $function, 
$file, $includable );
        }
 
        public function doesWrites() {
@@ -127,7 +134,7 @@
                return Preferences::getFormObject( $user, $context );
        }
 
-       private function showResetForm() {
+       protected function showResetForm() {
                if ( !$this->getUser()->isAllowed( 'editmyoptions' ) ) {
                        throw new PermissionsError( 'editmyoptions' );
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/389660
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I390e9d46fd2b8d4d8a1f9fd250c964a696b48244
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Samwilson <s...@samwilson.id.au>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to