jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/388751 )
Change subject: Don't use @ for error suppression
......................................................................
Don't use @ for error suppression
Use an extra isset() call instead.
Change-Id: I10042a982fbde3e42be33d60a378eb74b28089d7
---
M NamespacePopups.hooks.php
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/NamespacePopups.hooks.php b/NamespacePopups.hooks.php
index 095aa36..84187f6 100644
--- a/NamespacePopups.hooks.php
+++ b/NamespacePopups.hooks.php
@@ -87,8 +87,13 @@
foreach ( $oldLinks as $linkInfo ) {
list( $linkNS, $remains ) = $linkInfo;
- $popupNS = isset(
$wgNamespacePopupsNamespaceMap[$linkNS] )
- ? $wgNamespacePopupsNamespaceMap[$linkNS] :
@$wgNamespacePopupsNamespaceMap['*'];
+ if ( isset( $wgNamespacePopupsNamespaceMap[$linkNS] ) )
{
+ $popupNS =
$wgNamespacePopupsNamespaceMap[$linkNS];
+ } elseif ( isset( $wgNamespacePopupsNamespaceMap['*'] )
) {
+ $popupNS = $wgNamespacePopupsNamespaceMap['*'];
+ } else {
+ $popupNS = null;
+ }
if ( !$popupNS ) {
continue;
}
--
To view, visit https://gerrit.wikimedia.org/r/388751
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10042a982fbde3e42be33d60a378eb74b28089d7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NamespacePopups
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
