ItSpiderman has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/389977 )

Change subject: Fix for fatal when link is broken
......................................................................

Fix for fatal when link is broken

Eventhough i couldnt reproduce it since, i found a fatal in error_log,
saying File object was null

Change-Id: Icf520ce7820107ba7908e870c531577ba775353f
---
M includes/api/BSApiContextMenuTasks.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceContextMenu 
refs/changes/77/389977/1

diff --git a/includes/api/BSApiContextMenuTasks.php 
b/includes/api/BSApiContextMenuTasks.php
index 3fa76dd..f7a79dd 100644
--- a/includes/api/BSApiContextMenuTasks.php
+++ b/includes/api/BSApiContextMenuTasks.php
@@ -46,6 +46,9 @@
 
                if( $oTitle->getNamespace() === NS_FILE && $oTitle->exists() ) {
                        $oFile = wfFindFile( $oTitle );
+                       if( $oFile->exists() === false ) {
+                               return $this->returnItems( $oResult, $aItems );
+                       }
                        $this->makeFileItems( $aItems, $oTitle, $oFile );
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/389977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf520ce7820107ba7908e870c531577ba775353f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceContextMenu
Gerrit-Branch: master
Gerrit-Owner: ItSpiderman <d.savulje...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to