Ladsgroup has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/389999 )

Change subject: Drop oresc_rev_predicted_model index on ores_classification
......................................................................

Drop oresc_rev_predicted_model index on ores_classification

It's too restrictive and it's not useful

Bug: T180026
Change-Id: I61958ec0823ebfa3976fc7396a938f6055982a8c
---
M includes/Hooks.php
M sql/ores_classification.sql
A sql/patch-ores-classification-indexes-part-ii.sql
3 files changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ORES 
refs/changes/99/389999/1

diff --git a/includes/Hooks.php b/includes/Hooks.php
index 2f3d69e..b0d53aa 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -50,6 +50,8 @@
                        __DIR__ . '/../sql/patch-ores-model-indexes.sql' );
                $updater->addExtensionIndex( 'ores_classification', 
'oresc_model_class_prob',
                        __DIR__ . 
'/../sql/patch-ores-classification-model-class-prob-index.sql' );
+               $updater->dropExtensionIndex( 'ores_classification', 
'oresc_rev',
+                       __DIR__ . 
'/../sql/patch-ores-classification-indexes-part-ii.sql' );
        }
 
        /**
diff --git a/sql/ores_classification.sql b/sql/ores_classification.sql
index 2f886af..639c565 100644
--- a/sql/ores_classification.sql
+++ b/sql/ores_classification.sql
@@ -19,5 +19,4 @@
 ) /*$wgDBTableOptions*/;
 
 CREATE UNIQUE INDEX /*i*/oresc_rev_model_class ON /*_*/ores_classification 
(oresc_rev, oresc_model, oresc_class);
-CREATE UNIQUE INDEX /*i*/oresc_rev_predicted_model ON /*_*/ores_classification 
(oresc_rev, oresc_is_predicted, oresc_model);
 CREATE INDEX /*i*/oresc_model_class_prob ON /*_*/ores_classification 
(oresc_model, oresc_class, oresc_probability);
diff --git a/sql/patch-ores-classification-indexes-part-ii.sql 
b/sql/patch-ores-classification-indexes-part-ii.sql
new file mode 100644
index 0000000..f69bfed
--- /dev/null
+++ b/sql/patch-ores-classification-indexes-part-ii.sql
@@ -0,0 +1,6 @@
+--
+-- patch-ores-classification-indexes-part-ii.sql
+--
+-- Drop too restrictive and not useful index
+
+DROP INDEX /*i*/oresc_rev_predicted_model ON /*_*/ores_classification;

-- 
To view, visit https://gerrit.wikimedia.org/r/389999
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61958ec0823ebfa3976fc7396a938f6055982a8c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to