Gergő Tisza has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390135 )
Change subject: Fix iw lookup warnings when interwiki table is empty
......................................................................
Fix iw lookup warnings when interwiki table is empty
Change-Id: I49732cbd42107b4937bdeaa20500b126518c8cc5
---
M src/ReverseInterwikiLookup.php
M tests/src/ReverseInterwikiLookupTest.php
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ReadingLists
refs/changes/35/390135/1
diff --git a/src/ReverseInterwikiLookup.php b/src/ReverseInterwikiLookup.php
index 468d695..3458015 100644
--- a/src/ReverseInterwikiLookup.php
+++ b/src/ReverseInterwikiLookup.php
@@ -65,6 +65,7 @@
*/
protected function getPrefixTable() {
if ( $this->prefixTable === null ) {
+ $this->prefixTable = [];
$iwData = $this->interwikiLookup->getAllPrefixes( true
);
foreach ( $iwData as $iwRow ) {
$url = wfParseUrl( $iwRow['iw_url'] );
diff --git a/tests/src/ReverseInterwikiLookupTest.php
b/tests/src/ReverseInterwikiLookupTest.php
index f524d8b..1001a8b 100644
--- a/tests/src/ReverseInterwikiLookupTest.php
+++ b/tests/src/ReverseInterwikiLookupTest.php
@@ -38,6 +38,7 @@
'exact match 2' => [ 'b', 'en.wikibooks.org', $iwTable
],
'cross-project + cross-lang' => [ [ 'b', 'de', ],
'de.wikibooks.org', $iwTable ],
'invalid language code' => [ null,
'nosuchlang.wikipedia.org', $iwTable ],
+ 'empty table' => [ null, 'foo.bar', [] ],
];
}
--
To view, visit https://gerrit.wikimedia.org/r/390135
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49732cbd42107b4937bdeaa20500b126518c8cc5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ReadingLists
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
