awjrichards has uploaded a new change for review.
https://gerrit.wikimedia.org/r/56346
Change subject: Ensure userlogin.js checks for wgMFLoginHandshakeUrl before
handhsaking
......................................................................
Ensure userlogin.js checks for wgMFLoginHandshakeUrl before handhsaking
Without this, if you leave wgMFLoginHandhakeUrl == false, this will
attempt to redierct you to /null!
Change-Id: I92e2ce8fe21682fcd6022f1f0f4296e5fb6c1218
---
M javascripts/specials/userlogin.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/46/56346/1
diff --git a/javascripts/specials/userlogin.js
b/javascripts/specials/userlogin.js
index b49a72d..f1ba16b 100644
--- a/javascripts/specials/userlogin.js
+++ b/javascripts/specials/userlogin.js
@@ -6,7 +6,7 @@
try {
// redirect to Commons Special:LoginHandshake if it's the first
visit
if (
- 'localStorage' in window && window.localStorage !==
null &&
+ loginHandshakeUrl && 'localStorage' in window &&
window.localStorage !== null &&
!localStorage.getItem( 'loginHandshaked' )
) {
if ( document.referrer !== loginHandshakeUrl ) {
--
To view, visit https://gerrit.wikimedia.org/r/56346
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92e2ce8fe21682fcd6022f1f0f4296e5fb6c1218
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: awjrichards <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
