Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/390268 )

Change subject: WIP Run WebdriverIO tests using Firefox
......................................................................

WIP Run WebdriverIO tests using Firefox

Bug: T161697
Change-Id: I2b64646e7c89f52b1971835e510d28d8cacdea79
---
M package.json
M tests/selenium/pageobjects/page.js
M tests/selenium/specs/page.js
M tests/selenium/specs/user.js
M tests/selenium/wdio.conf.js
5 files changed, 6 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/68/390268/1

diff --git a/package.json b/package.json
index faca87d..31a3f81 100644
--- a/package.json
+++ b/package.json
@@ -4,7 +4,7 @@
     "test": "grunt test",
     "doc": "jsduck",
     "postdoc": "grunt copy:jsduck",
-    "selenium": "killall -0 chromedriver 2>/dev/null || chromedriver 
--url-base=/wd/hub --port=4444 & grunt webdriver:test; killall chromedriver"
+    "selenium": "killall -0 geckodriver 2>/dev/null || geckodriver & grunt 
webdriver:test; killall geckodriver"
   },
   "devDependencies": {
     "deepmerge": "1.3.2",
@@ -32,6 +32,6 @@
     "wdio-mocha-framework": "0.5.8",
     "wdio-sauce-service": "^0.3.1",
     "wdio-spec-reporter": "0.0.5",
-    "webdriverio": "4.6.2"
+    "webdriverio": "4.9.4"
   }
 }
diff --git a/tests/selenium/pageobjects/page.js 
b/tests/selenium/pageobjects/page.js
index 864bdae..9d6988a 100644
--- a/tests/selenium/pageobjects/page.js
+++ b/tests/selenium/pageobjects/page.js
@@ -5,7 +5,7 @@
                this.title = 'My Page';
        }
        open( path ) {
-               browser.url( '/index.php?title=' + path );
+               browser.url( 'w/index.php?title=' + path );
        }
 }
 module.exports = Page;
diff --git a/tests/selenium/specs/page.js b/tests/selenium/specs/page.js
index 06d3d60..1feba11 100644
--- a/tests/selenium/specs/page.js
+++ b/tests/selenium/specs/page.js
@@ -12,7 +12,6 @@
        before( function () {
                // disable VisualEditor welcome dialog
                UserLoginPage.open();
-               browser.localStorage( 'POST', { key: 've-beta-welcome-dialog', 
value: '1' } );
        } );
 
        beforeEach( function () {
diff --git a/tests/selenium/specs/user.js b/tests/selenium/specs/user.js
index 3f3872d..1442ed1 100644
--- a/tests/selenium/specs/user.js
+++ b/tests/selenium/specs/user.js
@@ -12,7 +12,6 @@
        before( function () {
                // disable VisualEditor welcome dialog
                UserLoginPage.open();
-               browser.localStorage( 'POST', { key: 've-beta-welcome-dialog', 
value: '1' } );
        } );
 
        beforeEach( function () {
diff --git a/tests/selenium/wdio.conf.js b/tests/selenium/wdio.conf.js
index cf9da0c..5559dad 100644
--- a/tests/selenium/wdio.conf.js
+++ b/tests/selenium/wdio.conf.js
@@ -49,9 +49,6 @@
        //
        specs: [
                relPath( './tests/selenium/specs/**/*.js' ),
-               relPath( './extensions/*/tests/selenium/specs/**/*.js' ),
-               relPath( 
'./extensions/VisualEditor/modules/ve-mw/tests/selenium/specs/**/*.js' ),
-               relPath( './skins/*/tests/selenium/specs/**/*.js' ),
        ],
        // Patterns to exclude.
        exclude: [
@@ -86,12 +83,10 @@
                // 5 instances get started at a time.
                maxInstances: 1,
                //
-               browserName: 'chrome',
-               // Since Chrome v57 
https://bugs.chromium.org/p/chromedriver/issues/detail?id=1625
-               chromeOptions: {
-                       args: [ '--enable-automation' ]
-               }
+               browserName: 'firefox',
        } ],
+       // Path to chromedriver or geckodriver
+       path: '/',
        //
        // ===================
        // Test Configurations

-- 
To view, visit https://gerrit.wikimedia.org/r/390268
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b64646e7c89f52b1971835e510d28d8cacdea79
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to