Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/390298 )

Change subject: Move namespace_id and namespace_text to top level
......................................................................

Move namespace_id and namespace_text to top level

Bug: T177431
Change-Id: I31fecfc4d15f18003ea9f0f168ea9a32a2a0d626
---
M lib/mobile-util.js
M spec.yaml
2 files changed, 10 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/98/390298/1

diff --git a/lib/mobile-util.js b/lib/mobile-util.js
index b07197c..7e4cc1c 100644
--- a/lib/mobile-util.js
+++ b/lib/mobile-util.js
@@ -214,8 +214,6 @@
         title: title.getPrefixedDBKey(),
         normalized_title: lead.normalizedtitle,
         display_title: lead.displaytitle,
-        namespace_id: lead.ns,
-        namespace_name: lead.ns_text,
     };
 };
 
@@ -247,6 +245,8 @@
         type,
         title: lead.normalizedtitle,
         displaytitle: lead.displaytitle,
+        namespace_id: lead.ns,
+        namespace_text: lead.ns_text,
         titles: mUtil.buildTitleDictionary(title, lead),
         pageid: lead.id,
         thumbnail: lead.thumbnail,
diff --git a/spec.yaml b/spec.yaml
index d24f2be..f07a2db 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -679,12 +679,12 @@
               type: standard
               title: /.+/
               displaytitle: /.+/
+              namespace_id: /.+/
+              namespace_text: /.*/
               titles:
                 title: /.+/
                 normalized_title: /.+/
                 display_title: /.+/
-                namespace_id: /.+/
-                namespace_name: /.*/
               pageid: /.+/
               thumbnail:
                 source: /.+/
@@ -870,6 +870,12 @@
       displaytitle:
         type: string
         description: The page title how it should be shown to the user
+      namespace_id:
+        type: integer
+        description: the numeric ID for the page's namespace 
(https://www.mediawiki.org/wiki/Manual:Namespace)
+      namespace_text:
+        type: string
+        description: text name for the MediaWiki namespace
       titles:
         $ref: '#/definitions/titles_set'
       pageid:
@@ -1290,18 +1296,10 @@
       display_title:
         type: string
         description: the title as it should be displayed to the user
-      namespace_id:
-        type: integer
-        description: the numeric ID for the page's namespace 
(https://www.mediawiki.org/wiki/Manual:Namespace)
-      namespace_name:
-        type: string
-        description: text name for the MediaWiki namespace
     required:
       - title
       - normalized_title
       - display_title
-      - namespace_id
-      - namespace_name
     additionalProperties: false
 
   content_urls:

-- 
To view, visit https://gerrit.wikimedia.org/r/390298
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I31fecfc4d15f18003ea9f0f168ea9a32a2a0d626
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway <mhollo...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to