jenkins-bot has submitted this change and it was merged.
Change subject: Start outputting deprecation warnings when legacy linker
methods are called on skins.
......................................................................
Start outputting deprecation warnings when legacy linker methods are called on
skins.
Change-Id: I97b046739428176540ddd80e72a80d5feefe3fc9
---
M RELEASE-NOTES-1.21
M includes/Skin.php
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/RELEASE-NOTES-1.21 b/RELEASE-NOTES-1.21
index efa534a..ecb37d5 100644
--- a/RELEASE-NOTES-1.21
+++ b/RELEASE-NOTES-1.21
@@ -350,6 +350,7 @@
function, which is now deprecated).
* BREAKING CHANGE: The Services_JSON class has been removed; if necessary,
be sure to upgrade affected extensions at the same time (e.g. Collection).
+* Calling Linker methods using a skin will now output deprecation warnings.
== Compatibility ==
diff --git a/includes/Skin.php b/includes/Skin.php
index e5aedd9..a4cb9f4 100644
--- a/includes/Skin.php
+++ b/includes/Skin.php
@@ -1559,6 +1559,7 @@
function __call( $fname, $args ) {
$realFunction = array( 'Linker', $fname );
if ( is_callable( $realFunction ) ) {
+ wfDeprecated( get_class( $this ) . '::' . $fname,
'1.21' );
return call_user_func_array( $realFunction, $args );
} else {
$className = get_class( $this );
--
To view, visit https://gerrit.wikimedia.org/r/56406
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97b046739428176540ddd80e72a80d5feefe3fc9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Friesen <dan...@nadir-seen-fire.com>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
