Eevans has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/389742 )
Change subject: Log every retry warning
......................................................................
Log every retry warning
Element of least-surprise is for the number of WARN messages to match
the number of (failed) attempts (as that relates to `-a/--attempts`).
Change-Id: Id602e7f147e71ffcf4ce82c89ea64fae6a9986c2
---
M cassandra/tools/instances.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eevans: Looks good to me, approved
Mobrovac: Looks good to me, but someone else must approve
jenkins-bot: Verified
Filippo Giunchedi: Looks good to me, but someone else must approve
diff --git a/cassandra/tools/instances.py b/cassandra/tools/instances.py
index f773b77..cadc687 100644
--- a/cassandra/tools/instances.py
+++ b/cassandra/tools/instances.py
@@ -81,7 +81,7 @@
self.__log_info("CQL (%s:%s) is UP", self.rpc_address,
self.native_transport_port)
listening = True
break
- elif (i % 2) == 0 and i < 9:
+ elif i < (len(attempts) - 1):
self.__log_warn(
"CQL (%s:%s) not listening (will retry)...",
self.rpc_address,
--
To view, visit https://gerrit.wikimedia.org/r/389742
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id602e7f147e71ffcf4ce82c89ea64fae6a9986c2
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/cassandra-tools-wmf
Gerrit-Branch: master
Gerrit-Owner: Eevans <eev...@wikimedia.org>
Gerrit-Reviewer: Eevans <eev...@wikimedia.org>
Gerrit-Reviewer: Elukey <ltosc...@wikimedia.org>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: Muehlenhoff <mmuhlenh...@wikimedia.org>
Gerrit-Reviewer: Ppchelko <ppche...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
