Eevans has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/389743 )
Change subject: Use a more realistic defaults
......................................................................
Use a more realistic defaults
Some of our Cassandra clusters take a bit longer to startup these
days; Increase the number of attempts to be more inline with our
typical cluster restart times.
Change-Id: Icc91deceb6611a0da060cec7178ce1cd71d2e264
---
M c-foreach-restart
M cassandra/tools/instances.py
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Eevans: Looks good to me, approved
jenkins-bot: Verified
diff --git a/c-foreach-restart b/c-foreach-restart
index 0d756c2..a1ed75c 100755
--- a/c-foreach-restart
+++ b/c-foreach-restart
@@ -32,7 +32,7 @@
def parse_args():
parser = argparse.ArgumentParser(description="Cassandra instance
restarter")
- parser.add_argument("-a", "--attempts", metavar="ATTEMPTS", default=10,
type=int,
+ parser.add_argument("-a", "--attempts", metavar="ATTEMPTS", default=20,
type=int,
help="Maximum number of times to check if service is
up after restarting.")
parser.add_argument("-r", "--retry", metavar="RETRY", default=6, type=int,
help="Number seconds between connection attempts, in
seconds.")
diff --git a/cassandra/tools/instances.py b/cassandra/tools/instances.py
index cadc687..66ad5af 100644
--- a/cassandra/tools/instances.py
+++ b/cassandra/tools/instances.py
@@ -50,7 +50,7 @@
self.nodetool = Nodetool("localhost", self.jmx_port)
- def restart(self, attempts=10, retry=6, post_shutdown=None):
+ def restart(self, attempts=20, retry=6, post_shutdown=None):
"""
Restarts this Cassandra instance.
"""
--
To view, visit https://gerrit.wikimedia.org/r/389743
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc91deceb6611a0da060cec7178ce1cd71d2e264
Gerrit-PatchSet: 2
Gerrit-Project: operations/debs/cassandra-tools-wmf
Gerrit-Branch: master
Gerrit-Owner: Eevans <eev...@wikimedia.org>
Gerrit-Reviewer: Eevans <eev...@wikimedia.org>
Gerrit-Reviewer: Elukey <ltosc...@wikimedia.org>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: Muehlenhoff <mmuhlenh...@wikimedia.org>
Gerrit-Reviewer: Ppchelko <ppche...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
