jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/390467 )
Change subject: RCFilters: fix call to changesListModel.update() ...................................................................... RCFilters: fix call to changesListModel.update() Followup to Ie2bc4fe4bd19103b513e4753e59f4adb295fbafa 3rd argument is {string} noResultsDetails Type of no result error ... not a boolean (isTimeout) like it used to. Change-Id: I7766ed082eb2f4e43a89e3b5c0fb2e61bf5f1169 --- M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js index d519648..5386291 100644 --- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js +++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js @@ -262,7 +262,7 @@ this.changesListModel.update( pieces.changes, pieces.fieldset, - pieces.noResultsDetails === 'NO_RESULTS_TIMEOUT', + pieces.noResultsDetails, true // We're using existing DOM elements ); } -- To view, visit https://gerrit.wikimedia.org/r/390467 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7766ed082eb2f4e43a89e3b5c0fb2e61bf5f1169 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Sbisson <sbis...@wikimedia.org> Gerrit-Reviewer: Catrope <r...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits