WMDE-Fisch has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391180 )

Change subject: Add missing @throws in Importers
......................................................................

Add missing @throws in Importers

Change-Id: I02760e59d73f4278cca87483ab4578b6e76b2324
---
M includes/import/WikiImporter.php
M maintenance/importDump.php
2 files changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/80/391180/1

diff --git a/includes/import/WikiImporter.php b/includes/import/WikiImporter.php
index a1f7e0c..fb74865 100644
--- a/includes/import/WikiImporter.php
+++ b/includes/import/WikiImporter.php
@@ -546,8 +546,9 @@
 
        /**
         * Primary entry point
-        * @throws MWException
         * @return bool
+        * @throws Exception
+        * @throws MWException
         */
        public function doImport() {
                // Calls to reader->read need to be wrapped in calls to
@@ -848,6 +849,7 @@
         * @param array $pageInfo
         * @param array $revisionInfo
         * @return bool|mixed
+        * @throws MWException
         */
        private function processRevision( $pageInfo, $revisionInfo ) {
                global $wgMaxArticleSize;
diff --git a/maintenance/importDump.php b/maintenance/importDump.php
index 206c7ee..4b92441 100644
--- a/maintenance/importDump.php
+++ b/maintenance/importDump.php
@@ -140,6 +140,7 @@
        /**
         * @param Title|Revision $obj
         * @return bool
+        * @throws MWException
         */
        private function skippedNamespace( $obj ) {
                $title = null;

-- 
To view, visit https://gerrit.wikimedia.org/r/391180
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I02760e59d73f4278cca87483ab4578b6e76b2324
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch <christoph.jau...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to