jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/391194 )
Change subject: Test for Revision::getRecentChange ...................................................................... Test for Revision::getRecentChange Bug: T180210 Change-Id: I67a425676236af77063ad759f4515742533436ca --- M tests/phpunit/includes/RevisionDbTestBase.php 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Daniel Kinzler: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/phpunit/includes/RevisionDbTestBase.php b/tests/phpunit/includes/RevisionDbTestBase.php index 5e8b0c8..2fdf590 100644 --- a/tests/phpunit/includes/RevisionDbTestBase.php +++ b/tests/phpunit/includes/RevisionDbTestBase.php @@ -160,6 +160,30 @@ } /** + * @covers Revision::getRecentChange + */ + public function testGetRecentChange() { + $rev = $this->testPage->getRevision(); + $recentChange = $rev->getRecentChange(); + + // Make sure various attributes look right / the correct entry has been retrieved. + $this->assertEquals( $rev->getTimestamp(), $recentChange->getAttribute( 'rc_timestamp' ) ); + $this->assertEquals( + $rev->getTitle()->getNamespace(), + $recentChange->getAttribute( 'rc_namespace' ) + ); + $this->assertEquals( + $rev->getTitle()->getDBkey(), + $recentChange->getAttribute( 'rc_title' ) + ); + $this->assertEquals( $rev->getUser(), $recentChange->getAttribute( 'rc_user' ) ); + $this->assertEquals( $rev->getUserText(), $recentChange->getAttribute( 'rc_user_text' ) ); + $this->assertEquals( $rev->getComment(), $recentChange->getAttribute( 'rc_comment' ) ); + $this->assertEquals( $rev->getPage(), $recentChange->getAttribute( 'rc_cur_id' ) ); + $this->assertEquals( $rev->getId(), $recentChange->getAttribute( 'rc_this_oldid' ) ); + } + + /** * @covers Revision::insertOn */ public function testInsertOn_success() { -- To view, visit https://gerrit.wikimedia.org/r/391194 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67a425676236af77063ad759f4515742533436ca Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits