Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391332 )
Change subject: Fix alignment of ConstraintLayouts for RTL. ...................................................................... Fix alignment of ConstraintLayouts for RTL. When using ConstraintLayout, one shouldn't forget to set the constraintStart attribute. Even though things might appear correct in a LTR configuration, they may be broken in RTL. Bug: T180533 Change-Id: Ib407615e5521f972bfbcbb416baff23a0d686dd8 --- M app/src/main/res/layout/view_card_action_footer.xml M app/src/main/res/layout/view_static_card.xml 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/32/391332/1 diff --git a/app/src/main/res/layout/view_card_action_footer.xml b/app/src/main/res/layout/view_card_action_footer.xml index 76efc0d..896d88c 100644 --- a/app/src/main/res/layout/view_card_action_footer.xml +++ b/app/src/main/res/layout/view_card_action_footer.xml @@ -13,6 +13,7 @@ android:layout_height="match_parent" android:paddingLeft="16dp" android:paddingRight="16dp" + app:layout_constraintStart_toStartOf="parent" android:clickable="true" android:background="?attr/selectableItemBackgroundBorderless"> diff --git a/app/src/main/res/layout/view_static_card.xml b/app/src/main/res/layout/view_static_card.xml index 1e09338..9eaddde 100644 --- a/app/src/main/res/layout/view_static_card.xml +++ b/app/src/main/res/layout/view_static_card.xml @@ -75,6 +75,7 @@ android:layout_height="48dp" android:paddingLeft="16dp" android:paddingRight="16dp" + app:layout_constraintStart_toStartOf="parent" android:clickable="true" android:background="?attr/selectableItemBackgroundBorderless" app:layout_constraintTop_toBottomOf="@id/view_static_card_container"> -- To view, visit https://gerrit.wikimedia.org/r/391332 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib407615e5521f972bfbcbb416baff23a0d686dd8 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant <dbr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits