Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/390083 )
Change subject: webperf: Refactor tests to directly associate expected data with cases ...................................................................... webperf: Refactor tests to directly associate expected data with cases Previously we had a file with all input and a file with all output, which is pretty hard to review and basically only helps catch errors when the intent is to change nothing in the output. Whenever we do make a change in the output, the expected data was sufficiently mixed up that one basically ends up just recreating it with the new input with no feasible way to review. Hopefully this new structure will make it easier to review by having the input and expected output directly associated with each another, and in the same file. Change-Id: Ibb6c11476535e45490a5147294099d1965a3f970 --- D modules/webperf/files/navtiming_expected.txt M modules/webperf/files/navtiming_fixture.yaml M modules/webperf/files/navtiming_test.py 3 files changed, 467 insertions(+), 6,775 deletions(-) Approvals: jenkins-bot: Verified Gilles: Looks good to me, but someone else must approve Dzahn: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/390083 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb6c11476535e45490a5147294099d1965a3f970 Gerrit-PatchSet: 4 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: Gilles <gdu...@wikimedia.org> Gerrit-Reviewer: Phedenskog <phedens...@wikimedia.org> Gerrit-Reviewer: Volans <rcocci...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
