Lucas Werkmeister (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391799 )
Change subject: Minor fixes to cache code
......................................................................
Minor fixes to cache code
Bug: T179844
Change-Id: I53d3a9dfe98815c180bcb4ec8b9187d07cfdd58f
---
M includes/ConstraintCheck/Cache/CachedEntityIds.php
M tests/phpunit/Cache/CachedBoolTest.php
M tests/phpunit/Cache/CachedEntityIdsTest.php
M tests/phpunit/Cache/CachedQueryResultsTest.php
4 files changed, 9 insertions(+), 9 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
refs/changes/99/391799/1
diff --git a/includes/ConstraintCheck/Cache/CachedEntityIds.php
b/includes/ConstraintCheck/Cache/CachedEntityIds.php
index 15e2385..9f02d4a 100644
--- a/includes/ConstraintCheck/Cache/CachedEntityIds.php
+++ b/includes/ConstraintCheck/Cache/CachedEntityIds.php
@@ -13,7 +13,7 @@
class CachedEntityIds extends CachedArray {
/**
- * @return (EntityId|null) The entity IDs.
+ * @return (EntityId|null)[] The entity IDs.
*/
public function getArray() {
return parent::getArray();
diff --git a/tests/phpunit/Cache/CachedBoolTest.php
b/tests/phpunit/Cache/CachedBoolTest.php
index 6af2973..f71fe38 100644
--- a/tests/phpunit/Cache/CachedBoolTest.php
+++ b/tests/phpunit/Cache/CachedBoolTest.php
@@ -20,18 +20,18 @@
$bool = true;
$cm = CachingMetadata::fresh();
- $ca = new CachedBool( $bool, $cm );
+ $cb = new CachedBool( $bool, $cm );
- $this->assertSame( $bool, $ca->getBool() );
+ $this->assertSame( $bool, $cb->getBool() );
}
public function testGetCachingMetadata() {
$bool = false;
$cm = CachingMetadata::ofMaximumAgeInSeconds( 42 );
- $ca = new CachedBool( $bool, $cm );
+ $cb = new CachedBool( $bool, $cm );
- $this->assertSame( $cm, $ca->getCachingMetadata() );
+ $this->assertSame( $cm, $cb->getCachingMetadata() );
}
}
diff --git a/tests/phpunit/Cache/CachedEntityIdsTest.php
b/tests/phpunit/Cache/CachedEntityIdsTest.php
index da8fe10..df8436c 100644
--- a/tests/phpunit/Cache/CachedEntityIdsTest.php
+++ b/tests/phpunit/Cache/CachedEntityIdsTest.php
@@ -21,9 +21,9 @@
$array = [ 'boolean' => true ];
$cm = CachingMetadata::fresh();
- $ca = new CachedEntityIds( $array, $cm );
+ $cei = new CachedEntityIds( $array, $cm );
- $this->assertSame( $array, $ca->getArray() );
+ $this->assertSame( $array, $cei->getArray() );
}
}
diff --git a/tests/phpunit/Cache/CachedQueryResultsTest.php
b/tests/phpunit/Cache/CachedQueryResultsTest.php
index a639ff7..93282f5 100644
--- a/tests/phpunit/Cache/CachedQueryResultsTest.php
+++ b/tests/phpunit/Cache/CachedQueryResultsTest.php
@@ -21,9 +21,9 @@
$array = [ 'boolean' => true ];
$cm = CachingMetadata::fresh();
- $ca = new CachedQueryResults( $array, $cm );
+ $cqr = new CachedQueryResults( $array, $cm );
- $this->assertSame( $array, $ca->getArray() );
+ $this->assertSame( $array, $cqr->getArray() );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/391799
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I53d3a9dfe98815c180bcb4ec8b9187d07cfdd58f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <lucas.werkmeis...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
