jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/390243 )
Change subject: Import wikimedia-ui-base in SpecialConstraintReportPage.less ...................................................................... Import wikimedia-ui-base in SpecialConstraintReportPage.less This lets us drop the last hard-coded color values. Change-Id: I4b332ad6adaee6e1d7e8c591c5749b88cc7b0933 --- M extension.json M modules/SpecialConstraintReportPage.less 2 files changed, 9 insertions(+), 8 deletions(-) Approvals: jenkins-bot: Verified Thiemo Mättig (WMDE): Looks good to me, approved diff --git a/extension.json b/extension.json index bf7f0e8..ea185f2 100644 --- a/extension.json +++ b/extension.json @@ -47,7 +47,10 @@ "ResourceModules": { "SpecialConstraintReportPage": { "styles": "modules/SpecialConstraintReportPage.less", - "scripts": "modules/SpecialConstraintReportPage.js" + "scripts": "modules/SpecialConstraintReportPage.js", + "dependencies": [ + "oojs-ui-core.styles" + ] }, "wikibase.quality.constraints.icon": { "class": "ResourceLoaderImageModule", diff --git a/modules/SpecialConstraintReportPage.less b/modules/SpecialConstraintReportPage.less index e0b8467..448cfbe 100644 --- a/modules/SpecialConstraintReportPage.less +++ b/modules/SpecialConstraintReportPage.less @@ -1,7 +1,5 @@ @import 'mediawiki.ui/variables'; - -/* named colors refer to the Wikimedia Style Guide, https://wikimedia.github.io/WikimediaUI-Style-Guide/visual-style_colors.html */ -/* TODO use some Less import for those as well (not part of 'mediawiki.ui/variables') */ +@import '../../lib/oojs-ui/wikimedia-ui-base'; /* Entity id form */ form { @@ -24,11 +22,11 @@ } .wbqc-status-compliance { - color: #00af89; /* Green50 */ + color: @wmui-color-green50; } .wbqc-status-exception { - color: #14866d; /* Green30 */ + color: @wmui-color-green30; } .wbqc-status-violation { @@ -49,7 +47,7 @@ } .wbqc-status-warning { - color: #ac6600; /* Yellow30 */ + color: @wmui-color-yellow30; } /* Tooltip */ @@ -61,7 +59,7 @@ .wbqc-tooltip { margin-top: -40px; margin-left: -5px; - background-color: #f8f9fa; /* Base90 */ + background-color: @background-color-framed; border: 1px solid @colorPlaceholder; border-radius: 5px; box-shadow: 2px 2px 1px rgba( 0, 0, 0, 0.2 ); -- To view, visit https://gerrit.wikimedia.org/r/390243 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b332ad6adaee6e1d7e8c591c5749b88cc7b0933 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints Gerrit-Branch: master Gerrit-Owner: Lucas Werkmeister (WMDE) <lucas.werkmeis...@wikimedia.de> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.kr...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits