Hashar has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392037 )
Change subject: Add tox and pass flake8
......................................................................
Add tox and pass flake8
Bug: T180328
Change-Id: Id337306215687db44914c1045bf88186b1e749c4
---
M dumpstatus.py
A tox.ini
M utils.py
3 files changed, 12 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/dumps/statusapi
refs/changes/37/392037/1
diff --git a/dumpstatus.py b/dumpstatus.py
index 0d714f3..9362693 100644
--- a/dumpstatus.py
+++ b/dumpstatus.py
@@ -1,6 +1,3 @@
-import sys
-import os
-sys.path.append(os.path.dirname(__file__))
from urlparse import parse_qs
from utils import Config, WikiList
from wiki_info_factory import WikiInfoFactory
@@ -40,7 +37,7 @@
body = '\n'.join(wiki_entries)
start_response('200 OK', [('Content-Type', 'application/json')])
return[body]
- except:
+ except Exception:
start_response('500 Internal Server Error', [('Content-Type',
'text/plain')])
return["The dumps API application ran into problems. "
"Please check your parameters and try again."]
diff --git a/tox.ini b/tox.ini
new file mode 100644
index 0000000..b981610
--- /dev/null
+++ b/tox.ini
@@ -0,0 +1,10 @@
+[tox]
+# no setup.py
+skipsdist = true
+
+[testenv:flake8]
+deps = flake8
+commands = flake8
+
+[flake8]
+max-line-length = 100
diff --git a/utils.py b/utils.py
index ba066ad..d6ac443 100644
--- a/utils.py
+++ b/utils.py
@@ -87,7 +87,7 @@
for dirname in os.listdir(os.path.join(self.dumpsdir, wiki)):
if digits.match(dirname):
dates.append(dirname)
- except OSError as ex:
+ except OSError:
return None
dates = dates.reverse()
return dates[0]
--
To view, visit https://gerrit.wikimedia.org/r/392037
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id337306215687db44914c1045bf88186b1e749c4
Gerrit-PatchSet: 1
Gerrit-Project: operations/dumps/statusapi
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
