jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/391534 )

Change subject: Revision::userCanBitfield test fallback to $wgUser
......................................................................


Revision::userCanBitfield test fallback to $wgUser

Bug: T180210
Change-Id: Ibda256d6fdd8762e0e90748d71034979e2de106f
---
M tests/phpunit/includes/RevisionDbTestBase.php
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Daniel Kinzler: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/phpunit/includes/RevisionDbTestBase.php 
b/tests/phpunit/includes/RevisionDbTestBase.php
index 2fdf590..20e69ae 100644
--- a/tests/phpunit/includes/RevisionDbTestBase.php
+++ b/tests/phpunit/includes/RevisionDbTestBase.php
@@ -1326,6 +1326,16 @@
                        $expected,
                        Revision::userCanBitfield( $bitField, $field, $user, 
$title )
                );
+
+               // Fallback to $wgUser
+               $this->setMwGlobals(
+                       'wgUser',
+                       $user
+               );
+               $this->assertSame(
+                       $expected,
+                       Revision::userCanBitfield( $bitField, $field, null, 
$title )
+               );
        }
 
        public function provideUserCan() {

-- 
To view, visit https://gerrit.wikimedia.org/r/391534
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibda256d6fdd8762e0e90748d71034979e2de106f
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.kr...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to