Brion VIBBER has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392574 )
Change subject: Fix audio/video player regression ...................................................................... Fix audio/video player regression Fixes regression from a mistaken overfix in I241d1e Bug: T169385 Change-Id: I30c71e92f0b475f3cecc03c5a2b869e7002c0862 --- M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/74/392574/1 diff --git a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js index 0b6871a..189485b 100644 --- a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js +++ b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js @@ -745,7 +745,8 @@ } // Set up the new embedObj mw.log( 'EmbedPlayer::updatePlaybackInterface: embedding with ' + this.selectedPlayer.library ); - this.selectedPlayer.on('load', function() { + // Note this is not a jQuery event handler, but a call with a callback: + this.selectedPlayer.load(function() { _this.updateLoadedPlayerInterface( callback ); }); }, -- To view, visit https://gerrit.wikimedia.org/r/392574 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I30c71e92f0b475f3cecc03c5a2b869e7002c0862 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Brion VIBBER <br...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits