jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/393022 )
Change subject: Improve logging for non-existent categories in the database
......................................................................
Improve logging for non-existent categories in the database
Suggested by Chad in the review for 3a8d3b9e0.
Bug: T179423
Change-Id: I9286ae33bdb3b0b50aa6f1619402caa5486682e3
---
M includes/Database.php
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Database.php b/includes/Database.php
index 2f9c778..4a2d89e 100644
--- a/includes/Database.php
+++ b/includes/Database.php
@@ -21,7 +21,7 @@
namespace MediaWiki\Linter;
use FormatJson;
-use MWExceptionHandler;
+use MediaWiki\Logger\LoggerFactory;
/**
* Database logic
@@ -84,7 +84,10 @@
try {
$name = ( new CategoryManager() )->getCategoryName(
$row->linter_cat );
} catch ( MissingCategoryException $e ) {
- MWExceptionHandler::logException( $e );
+ LoggerFactory::getInstance( 'Linter' )->error(
+ 'Could not find name for id: {linter_cat}',
+ [ 'linter_cat' => $row->linter_cat ]
+ );
return false;
}
return new LintError(
--
To view, visit https://gerrit.wikimedia.org/r/393022
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9286ae33bdb3b0b50aa6f1619402caa5486682e3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Linter
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
