Petar.petkovic has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393578 )
Change subject: Prevent empty chart flashing on CX dashboard
......................................................................
Prevent empty chart flashing on CX dashboard
- Change appearance behavior of CX stats card:
* Old behavior displays empty stats card in CX dashboard,
which is populated or removed after user statistics are loaded.
* New behavior does not display stats card initially. Stats card is
only displayed if there is data to show.
Bug: T179747
Change-Id: I9080464ce1a5e1ec2e411014f71add1ccf2036ba
---
M modules/widgets/translator/ext.cx.translator.js
M modules/widgets/translator/ext.cx.translator.less
2 files changed, 9 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/78/393578/1
diff --git a/modules/widgets/translator/ext.cx.translator.js
b/modules/widgets/translator/ext.cx.translator.js
index 74ee041..1652cf3 100644
--- a/modules/widgets/translator/ext.cx.translator.js
+++ b/modules/widgets/translator/ext.cx.translator.js
@@ -93,6 +93,10 @@
self.$canvas.prop( 'width', self.$widget.width() );
self.draw();
+
+ // Make statistics visible in dashboard sidebar,
+ // after all data is fetched and drawn on canvas
+ self.$widget.addClass( 'cx-translator--visible' );
} ).fail( function () {
self.$widget.remove();
} );
diff --git a/modules/widgets/translator/ext.cx.translator.less
b/modules/widgets/translator/ext.cx.translator.less
index 3baad07..e5a7c20 100644
--- a/modules/widgets/translator/ext.cx.translator.less
+++ b/modules/widgets/translator/ext.cx.translator.less
@@ -5,6 +5,7 @@
.mw-ui-one-whole;
background-color: #fff;
+ display: none;
margin-bottom: 1em;
border-radius: @borderRadius;
padding: 1em;
@@ -14,6 +15,10 @@
width: 47.5%;
margin-bottom: 0;
}
+
+ &--visible {
+ display: block;
+ }
}
.cx-translator__header {
--
To view, visit https://gerrit.wikimedia.org/r/393578
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9080464ce1a5e1ec2e411014f71add1ccf2036ba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Petar.petkovic <ppetko...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
